Skip to content

Additional reserved python keywords #7956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2018
Merged

Additional reserved python keywords #7956

merged 1 commit into from
Apr 3, 2018

Conversation

gs11
Copy link
Contributor

@gs11 gs11 commented Apr 2, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
    @taxpon @frol @mbohlool @cbornet @kenjones-cisco

Description of the PR

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

@frol
Copy link
Contributor

frol commented Apr 2, 2018

LGTM

@gs11
Copy link
Contributor Author

gs11 commented Apr 2, 2018

Since this should go into the 3.0.0 branch as well, is another PR required or would the same commit be merged into that branch?

@wing328 wing328 merged commit 240aad8 into swagger-api:master Apr 3, 2018
@wing328 wing328 added this to the v2.4.0 milestone Apr 3, 2018
@gs11 gs11 deleted the additional_reserved_python_keywords branch April 3, 2018 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants