You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For these schemas, the booleans are not stored correctly or are omitted or a parser error is raised:
BooleanTrue
ArrayWithTrueItems
ObjectWithTrueProperty
AllOfWithTrue
AnyOfWithTrue
OneOfWithTrue
NotWithTrue
UnevaluatedItemsTrue
UnevaluatedPropertiesTrue
PrefixitemsWithNoAdditionalItemsAllowed
PrefixitemsWithBooleanSchemas
Note: contains: true works and does not have this bug
This issue is the biggest contributor to 3.1.0 json schema test suite failures
I am working on adding 3.1.0 features to my code generation project at https://github.com/openapi-json-schema-tools/openapi-json-schema-generator and I use your parser.
One way that I am verifying that my 3.1.0 json schema features are implemented correctly is by running the json schema test suite against my implementation.
Bugs in swagger-parser require me to skip certain tests because the parser is omitting or incorrectly processing document data. Of all those bugs, this one blocks the largest number of json schema tests.
Per this PR I count >= 85 test schemas that are excluded by boolean schemas not being processed correctly. This could easily be > 170 tests that are skipped because each test schema can have n tests running against it.
The text was updated successfully, but these errors were encountered:
How would you want this addressed?
It looks like the most correct solution would be to change the return types to be Object like getAdditionalProperties does and that would be a breaking change.
Would you prefer something else like getNot remains unchanged and new getters are added like get310Not returns Object?
Boolean schemas (schemas where the value is true/false) are silently omitted or cause parsing errors
Swagger-parser version: 2.1.16
Sample spec:
For these schemas, the booleans are not stored correctly or are omitted or a parser error is raised:
Note:
contains: true
works and does not have this bugThis issue is the biggest contributor to 3.1.0 json schema test suite failures
I am working on adding 3.1.0 features to my code generation project at https://github.com/openapi-json-schema-tools/openapi-json-schema-generator and I use your parser.
One way that I am verifying that my 3.1.0 json schema features are implemented correctly is by running the json schema test suite against my implementation.
Bugs in swagger-parser require me to skip certain tests because the parser is omitting or incorrectly processing document data. Of all those bugs, this one blocks the largest number of json schema tests.
Per this PR I count >= 85 test schemas that are excluded by boolean schemas not being processed correctly. This could easily be > 170 tests that are skipped because each test schema can have n tests running against it.
The text was updated successfully, but these errors were encountered: