Skip to content
This repository was archived by the owner on Dec 25, 2024. It is now read-only.

Adds json schema test cases for 11 added keywords #241

Merged
merged 34 commits into from
Sep 28, 2023

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Sep 19, 2023

Adds (working) json schema test cases for 11 added 3.1.0 draft2020-12 json schema keywords

Keywords:

  1. const: only string values are working because of these bugs in swagger parser:
  2. contains
  3. dependentRequired
  4. dependentSchemas
  5. maxContains
  6. minContains
  7. patternProperties
    • Note: this update fixes a bug where additionalProperties did not consider patternProperties
  8. prefixItems
  9. propertyNames
  10. unevaluatedItems
  11. unevaluatedProperties

When working on this PR, these bugs were found in swagger parser:

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    mvn clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/python*.
    For Windows users, please run the script in Git BASH.

@spacether spacether changed the title Adds json schema test cases for 10 new keywords Adds json schema test cases for 11 added keywords Sep 21, 2023
@spacether spacether force-pushed the feat_adds_310_unit_tests branch from 230aea5 to 4c9be8f Compare September 23, 2023 19:09
@spacether spacether marked this pull request as ready for review September 28, 2023 20:14
@spacether spacether merged commit e50ffc7 into master Sep 28, 2023
@spacether spacether deleted the feat_adds_310_unit_tests branch September 28, 2023 20:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant