Skip to content

swc-linux-arm64-gnu is not included in the GitHub releases after v1.7.14. #9769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pan93412 opened this issue Dec 1, 2024 · 10 comments · Fixed by #10303
Closed

swc-linux-arm64-gnu is not included in the GitHub releases after v1.7.14. #9769

pan93412 opened this issue Dec 1, 2024 · 10 comments · Fixed by #10303
Labels
Milestone

Comments

@pan93412
Copy link
Contributor

pan93412 commented Dec 1, 2024

Describe the bug

f625035 did not fix it.


The filename is swc-linux-arm64-gnu.

It was present not after version v1.7.14: v1.7.14 (release). It has now disappeared. I suspect there was a change in the CI, but I cannot find the code that introduced this issue.

Discord discussion: discord.com/channels/889779439272075314/889785438938726441/1290999698328649738.

Input code

N/A

Config

N/A

Playground link (or link to the minimal reproduction)

https://play.swc.rs/?version=1.9.3&code=H4sIAAAAAAAAA0vOzyvOz0nVy8lP11DKSM3JyVfSBAAewMmrFAAAAA%3D%3D&config=H4sIAAAAAAAAA1WPSw7DIAwF9zkF8rrbdtE79BAWdSIifrKJVBTl7iUE0maH3xsz8jooBbNoeKq1PMsQkYX4nEsi2Sf8lARIOxTNJia49XaWvRrRCtVoOxpIyBOluiX3hoMNQajjLXPGmzH%2FC3VwkUnkCu4o%2BsnSVTc0JbjwXmrZDkk50qF%2FwA%2FqsvNjMPLqm4kXGrYvhlQioBQBAAA%3D

SWC Info output

N/A

Expected behavior

N/A

Actual behavior

No response

Version

1.9.3

Additional context

No response

@pan93412 pan93412 added the C-bug label Dec 1, 2024
pan93412 added a commit to database-playground/app-sf that referenced this issue Dec 1, 2024
@kdy1 kdy1 self-assigned this Dec 2, 2024
@kdy1 kdy1 added this to the Planned milestone Dec 2, 2024
@kdy1
Copy link
Member

kdy1 commented Dec 9, 2024

cc @Brooooooklyn Is linux-arm64-gnu valid napi target?

@Brooooooklyn
Copy link
Member

@pan93412 you can use swc-linux-arm64-musl

@pan93412
Copy link
Contributor Author

@pan93412 you can use swc-linux-arm64-musl

Yes, it works. However, there’s a library that downloads the SWC binary based on the runtime, and the missing of “glibc” prevents the library from downloading the latest SWC binaries. 😢

I may create a PR for that library to ensure it always downloads the musl version if napi-rs would not generate the glibc version anymore.

@kdy1 kdy1 removed their assignment Dec 31, 2024
@kdy1 kdy1 modified the milestone: Planned Dec 31, 2024
@pan93412
Copy link
Contributor Author

pan93412 commented Jan 3, 2025

I have the similar problem. My version is 1.10.4, platform is darwin and arm64. It throw "Failed to load native binding".

It might not be the same problem. You might need to open another issue to track it well.

@tbarrella
Copy link

Hello, I was wondering if I could help with this issue?

It looks like there are already builds for aarch64-unknown-linux-gnu, which I think is the same architecture as linux-arm64-gnu:

target: aarch64-unknown-linux-gnu

I'm not sure yet how publishing works; maybe a change is needed in one or both of these places to accommodate for the naming difference? and/or creating new directories in packages/ with arm64 -> aarch64?

guw added a commit to guw/swc that referenced this issue Apr 1, 2025
The Bash shell is needed in order to execute the build properly.
Fixes swc-project#9769.
@guw
Copy link
Contributor

guw commented Apr 1, 2025

Some findings from the actions/workflow log.

Publish 1.11.15
Publish 1.11.15-nightly

Output of "List binaries":

./packages/core/artifacts/bindings-core-1.11.15-nightly-20250401.1-aarch64-unknown-linux-gnu:
swc.linux-arm64-gnu.node

./packages/core/artifacts/bindings-core-1.11.15-nightly-20250[40](https://github.com/swc-project/swc/actions/runs/14187712145/job/39747289649#step:7:41)1.1-aarch64-unknown-linux-musl:
swc
swc.linux-arm64-musl.node

For aarch64-unknown-linux-gnu the swc binary is missing. This implies that the cp command was not successful either because the output does not exist or it was not run.

Scrolling through the "Build core ..." logs I noticed a possible issue:

115:  sh: 1: [[: not found

This leads me to believe that the cp is not executed because of the interesting command line. The last command executed seems to be rustup target add aarch64-unknown-linux-gnu and then it continues with corepack, skipping everything in between.

An indeed, the syntax is not supported in sh, which is the default shell of the docker-run-action action. See their doc for using bash.

@guw
Copy link
Contributor

guw commented Apr 1, 2025

@kdy1 I'd appreciate if you can push a release next, validating that this works and unblocking downstream consumers.

@kdy1
Copy link
Member

kdy1 commented Apr 1, 2025

https://github.com/swc-project/swc/actions/runs/14194792959

I did, thanks!

@kdy1
Copy link
Member

kdy1 commented Apr 4, 2025

Reopening as #10303 regressed Wasm plugins on x86_64-unknown-linux-gnu and I'm going to revert it

@kdy1 kdy1 reopened this Apr 4, 2025
@kdy1 kdy1 modified the milestone: Planned Apr 4, 2025
@kdy1 kdy1 closed this as completed in f4c2b80 Apr 4, 2025
@kdy1 kdy1 modified the milestones: Planned, v1.11.17 Apr 4, 2025
@swc-bot
Copy link
Collaborator

swc-bot commented May 4, 2025

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@swc-project swc-project locked as resolved and limited conversation to collaborators May 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging a pull request may close this issue.

6 participants