Skip to content

Commit d502d6f

Browse files
committed
Code review
1 parent eaeb642 commit d502d6f

File tree

4 files changed

+626
-523
lines changed

4 files changed

+626
-523
lines changed

Diff for: Sources/AsyncHTTPClient/ConnectionPool/HTTPExecutingRequest.swift

+3-3
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ import NIOHTTP1
7373
///
7474
/// 1. The request executor will call `willExecuteRequest(_: HTTPRequestExecutor) -> Bool` on the
7575
/// request. The request is expected to return `true`, if it wants to be executed and false if
76-
///     it was cancelled or failed, before this checkpoint. If the request returns `true` it is
76+
///     it was cancelled or failed, before this checkpoint. If the request returns `true` it is
7777
/// expected to keep a reference to the `HTTPRequestExecutor` that was passed to the request
7878
/// for further communication. If the request returned false, the executor shall inform the
7979
/// scheduling mechanism that it is ready to execute the a new request.
@@ -156,7 +156,7 @@ protocol HTTPScheduledRequest: AnyObject {
156156
///
157157
/// This happens if all available connections are currently in use
158158
func requestWasQueued(_: HTTPRequestScheduler)
159-
159+
160160
/// Fails the queued request, with an error.
161161
func fail(_ error: Error)
162162
}
@@ -198,7 +198,7 @@ protocol HTTPExecutingRequest: AnyObject {
198198

199199
/// The maximal `TimeAmount` that is allowed to pass between reads from the Channel.
200200
var idleReadTimeout: TimeAmount? { get }
201-
201+
202202
/// Will be called by the ChannelHandler to indicate that the request is going to be send.
203203
///
204204
/// This will be called on the Channel's EventLoop. Do **not block** during your execution!

0 commit comments

Comments
 (0)