Skip to content

Connect timeout defaults to 10 seconds, not indefinite #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
djones6 opened this issue Oct 23, 2019 · 1 comment · Fixed by #317
Closed

Connect timeout defaults to 10 seconds, not indefinite #118

djones6 opened this issue Oct 23, 2019 · 1 comment · Fixed by #317
Assignees
@artemredkin
Labels
good first issue Good for newcomers kind/bug Feature doesn't work as expected.
Milestone
1.2.2

Comments

@djones6
Copy link

djones6 commented Oct 23, 2019

The documentation for HTTPClient.Configuration.timeout suggests that the default behavior is not to time out.

However, in practice the client will produce a NIO.ChannelError.connectTimeout(.nanoseconds(10000000000)) - ie. 10 seconds - by default if the connection is not accepted within that time.

Setting this to a larger (or smaller) value does seem to work however.
@Lukasa
Copy link
Collaborator

Lukasa commented Oct 23, 2019

We should probably clean up the documentation. Defaulting to no timeout is a bad idea, IMO, but we should definitely clearly say what the actual behaviour is.

@artemredkin artemredkin self-assigned this Nov 2, 2019
@artemredkin artemredkin added this to the 1.2.1 milestone Jun 13, 2020
@artemredkin artemredkin added kind/bug Feature doesn't work as expected. help wanted good first issue Good for newcomers labels Jun 13, 2020
@artemredkin artemredkin modified the milestones: 1.2.1, 1.2.2 Aug 20, 2020
artemredkin added a commit to artemredkin/async-http-client that referenced this issue Nov 11, 2020
@artemredkin
Fixes default timeout documentation comment
251b777 
Motivation:
Right now documentation states that timrout defaults to no timeout, this
is no actually true, if timeout is not set NIO bootstrap defaults to 10
seconds connect timeout.

Modifications:
Updates documentation comment.

Result:
Closes swift-server#118
@artemredkin artemredkin mentioned this issue Nov 11, 2020
Merged
Lukasa pushed a commit that referenced this issue Nov 11, 2020
@artemredkin
Fixes default timeout documentation comment (#317)
0a8dddb 
Motivation:
Right now documentation states that timrout defaults to no timeout, this
is no actually true, if timeout is not set NIO bootstrap defaults to 10
seconds connect timeout.

Modifications:
Updates documentation comment.

Result:
Closes #118
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artemredkin artemredkin

Labels
good first issue Good for newcomers kind/bug Feature doesn't work as expected.
Projects
None yet
Milestone
1.2.2
Development

Successfully merging a pull request may close this issue.

Fixes default timeout documentation comment artemredkin/async-http-client
3 participants
@artemredkin @Lukasa @djones6