NoResult error on errors before TaskHandler is added #313
Comments
|
Another possible source of this issue is high load, SSL handshake takes too long and receive remote connection closed and fail handshakePromise on channel close |
artemredkin
added a commit
to artemredkin/async-http-client
that referenced
this issue
Nov 11, 2020
Motivation: Right now we only handle one type of SSL error: `.handshakeFailed`, but in reality a multitude of errors can happen, for example, remote party might just close connection that will in turn raise `.uncleanShutdown` error, that will be dropped on the floor and users will only get non-descriptive `NoResult` error. Modifications: Handle all types of SSL errors during handshake instead of just one. Adds a test. Result: Closes swift-server#313
artemredkin
added a commit
to artemredkin/async-http-client
that referenced
this issue
Nov 11, 2020
Motivation: Right now we only handle one type of SSL error: `.handshakeFailed`, but in reality a multitude of errors can happen, for example, remote party might just close connection that will in turn raise `.uncleanShutdown` error, that will be dropped on the floor and users will only get non-descriptive `NoResult` error. Modifications: Handle all types of SSL errors during handshake instead of just one. Adds a test. Result: Closes swift-server#313
artemredkin
added a commit
to artemredkin/async-http-client
that referenced
this issue
Nov 11, 2020
Motivation: Right now we only handle one type of SSL error: `.handshakeFailed`, but in reality a multitude of errors can happen, for example, remote party might just close connection that will in turn raise `.uncleanShutdown` error, that will be dropped on the floor and users will only get non-descriptive `NoResult` error. Modifications: Handle all types of SSL errors during handshake instead of just one. Adds a test. Result: Closes swift-server#313
artemredkin
added a commit
to artemredkin/async-http-client
that referenced
this issue
Nov 11, 2020
Motivation: Right now we only handle one type of SSL error: `.handshakeFailed`, but in reality a multitude of errors can happen, for example, remote party might just close connection that will in turn raise `.uncleanShutdown` error, that will be dropped on the floor and users will only get non-descriptive `NoResult` error. Modifications: Handle all types of SSL errors during handshake instead of just one. Adds a test. Result: Closes swift-server#313
artemredkin
added a commit
that referenced
this issue
Nov 11, 2020
Motivation: Right now we only handle one type of SSL error: `.handshakeFailed`, but in reality a multitude of errors can happen, for example, remote party might just close connection that will in turn raise `.uncleanShutdown` error, that will be dropped on the floor and users will only get non-descriptive `NoResult` error. Modifications: Handle all types of SSL errors during handshake instead of just one. Adds a test. Result: Closes #313 Co-authored-by: Cory Benfield <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If something other that
handshakeFailedhappens during SSL handshake (for exampleuncleanShutdown), we will getNoResulterror and real error will not be propagatedThe text was updated successfully, but these errors were encountered: