Skip to content

[HTTPConnectionPool] Performance: Cancel timer outside of stateLock #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fabianfett opened this issue Sep 24, 2021 · 1 comment
Open

[HTTPConnectionPool] Performance: Cancel timer outside of stateLock #439

fabianfett opened this issue Sep 24, 2021 · 1 comment

Comments

@fabianfett
Copy link
Member

Currently connection idle and request timers are cancelled inside the HTTPConnectionPool stateLock. We should move the cancellation (and only the cancellation) outside.
@fabianfett fabianfett added this to the HTTP/2 support milestone Sep 24, 2021
@fabianfett fabianfett mentioned this issue Sep 24, 2021
Merged
@fabianfett
Copy link
Member Author

Follow up to: #438 (comment)

@fabianfett fabianfett removed this from the HTTP/2 support milestone Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fabianfett