[HTTPConnectionPool] Fix request timer scheduling #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
force-pushed
the
ff-flaky-request-scheduling
branch
from
a8dc107 to
636b1f9
Compare
|
|
Lukasa
reviewed
Sep 24, 2021
| } | ||
| } | ||
| scheduled.forEach { $0.cancel() } | ||
| cancelTimer.cancel() |
There was a problem hiding this comment.
Should we do these cancels outside the lock?
There was a problem hiding this comment.
Will do at a later point, tracked here: #439
Lukasa
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If the allocator puts a request at the same address where another request has lived before and we ran into a timer race before, we run into an assertion. This can be seen in test runs here:
https://ci.swiftserver.group/job/async-http-client-swift55-prb/137/console
Changes
timerLockfromHTTPConnectionPoolResult