Remove parts of #139 relying on the Network framework #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the UNIX implementation across all platforms to avoid unnecessary complexity introduced by platform specific implementations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue:
The #139 bug fix is unfortunately not compatible with older (< macOS 10.14) Apple platforms versions where the
Networkframework didn't have theIPv4AddressandIPv6Addresstypes yet.Solution:
Use the UNIX implementation across all platforms to avoid unnecessary
complexity introduced by platform specific implementations.
Alternative solutions:
Runtime OS version checks dispatching the calls to the right implementation could also work but seem unnecessarily complicated compared to simply using the UNIX version everywhere.