Skip to content

add a public init to StreamWriter #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 5, 2020
Merged

add a public init to StreamWriter #161

merged 2 commits into from
Feb 5, 2020

Conversation

artemredkin
Copy link
Collaborator

Closes #158 by adding a public init to StreamWriter

Motivation:
Even though StreamWriter is public, its init is not, that makes using it in tests impossible.

Modifications:
add public init to StreamWriter

Result:
StreamWriter can no be instantiated by the clients of the library

@artemredkin artemredkin requested review from weissi and Lukasa February 5, 2020 16:02
weissi
weissi approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@weissi weissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@artemredkin artemredkin merged commit 70ad494 into master Feb 5, 2020
@artemredkin artemredkin deleted the make_writer_init_public branch February 5, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weissi weissi weissi approved these changes

@Lukasa Lukasa Awaiting requested review from Lukasa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StreamWriter does not have public constructor
2 participants
@artemredkin @weissi