Close idle pool connections #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Pooled connections should close at some point (see #168) Changes: - Add new poolingTimeout property to HTTPClient.Configuration, it's default value is .seconds(60), it can be set to nil if one wishes to disable this timeout. - Add relevant unit test
PopFlamingo
commented
Feb 26, 2020
| @@ -408,6 +409,8 @@ public class HTTPClient { | |||
| public var redirectConfiguration: RedirectConfiguration | |||
| /// Default client timeout, defaults to no timeouts. | |||
| public var timeout: Timeout | |||
| /// Timeout of pooled connections | |||
| public var poolingTimeout: TimeAmount? | |||
There was a problem hiding this comment.
Is this a good name for this setting?
There was a problem hiding this comment.
I'd make it a bit longer and more descriptive. Maybe maximumAllowedIdleTimeInConnectionPool or so? @Lukasa ?
There was a problem hiding this comment.
Ok, I set it to this for now, thanks.
PopFlamingo
commented
Feb 26, 2020
| tlsConfiguration: tlsConfiguration, | ||
| redirectConfiguration: redirectConfiguration, | ||
| timeout: timeout, | ||
| poolingTimeout: .seconds(60), |
There was a problem hiding this comment.
What do you think of the default 60 seconds timeout?
There was a problem hiding this comment.
I'm okay with this, @Lukasa ?
Fixes the race condition and adds a new test for it
pollingTimeout to maximumAllowedIdleTimeInConnectionPool
weissi
requested changes
Feb 27, 2020
test delayed close
This should fix the race. Deterministic tests are not possible with the current implementation
weissi
requested changes
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: Pooled connections should close at some point (see #168)
Changes:
maximumAllowedIdleTimeInConnectionPoolproperty toHTTPClient.Configuration, its default value is currently.seconds(60), and it can be set tonilif one wishes to disable this timeout.