make public API tests not use @testable again #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: AHC's tests were split in HTTPClientTests (which only use the public API) and HTTPClientInternalTests (which can use `internal` API by using `@testable`). At some point, the public API tests had `@testable` added to the AHC import which breaks this idea. Modification: Restore the intent by removing `@testable` and moving the 2 tests that needed it over. Result: Cleaner test suite.
ktoso
approved these changes
May 19, 2020
| @@ -12,7 +12,7 @@ | |||
| // | |||
| //===----------------------------------------------------------------------===// | |||
|
|
|||
| @testable import AsyncHTTPClient | |||
| /* NOT @testable */ import AsyncHTTPClient // Tests that need @testable go into HTTPClientInternalTests.swift | |||
There was a problem hiding this comment.
nice strategy to only have a specific file for those, +1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
AHC's tests were split in HTTPClientTests (which only use the public
API) and HTTPClientInternalTests (which can use
internalAPI by using@testable). At some point, the public API tests had@testableaddedto the AHC import which breaks this idea.
Modification:
Restore the intent by removing
@testableand moving the 2 tests thatneeded it over.
Result:
Cleaner test suite.