fix test faling with NIOTS #257
Conversation
| @@ -797,7 +797,7 @@ class HTTPClientInternalTests: XCTestCase { | |||
| } | |||
|
|
|||
| func testUncleanCloseThrows() { | |||
| let server = NIOHTTP1TestServer(group: self.clientGroup) | |||
| let server = NIOHTTP1TestServer(group: MultiThreadedEventLoopGroup(numberOfThreads: 1)) | |||
There was a problem hiding this comment.
I think we have self.serverGroup which could be used
There was a problem hiding this comment.
oooops, no one, good catch, thank you! no, we don't have that in internal tests class
There was a problem hiding this comment.
and its only monday... 😔
There was a problem hiding this comment.
oooops, no one, good catch, thank you! no, we don't have that in internal tests class
We should. I was probably lazy and changed only all of the non-internal tests
There was a problem hiding this comment.
so far we won't be using it anywhere else in that class (it usually just creates HTTPBin), still worth it?
There was a problem hiding this comment.
@artemredkin I think we should have a defaultHTTPBin and defaultClient and client/serverGroup all set up in setUp/tearDown. That makes tests more concise and therefore better
There was a problem hiding this comment.
but we don't need to do it right in this PR, up to you
Fixes test crashing on precondition.
Motivation:
When tests are executed on macOS client ELG is actually a
NIOTSELG, so it's incompatible withNIOHTTP1TestServerModifications:
Use separate ELG in
testUncleanCloseThrowsResult:
Closes #256