Updated swift-nio to 2.18.0 #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Due to using new ByteBuffer initializers from https://github.com/apple/swift-nio/releases/tag/2.18.0 in tests (specifically, `ByteBuffer(string: ...)`), the project will no longer compile if an older version of swift-nio is checked out. Modifications: Updated swift-nio from 2.16.0 to 2.18.0. Result: SPM should now grab the latest version of swift-nio if this version of async-http-client is used.
|
Can one of the admins verify this patch? |
3 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
@swift-server-bot test this please |
|
Happy as always to be solving the hard problems 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is worth opening a PR for, since any new checkouts will never see this issue, and it's only necessary due to tests, so please feel free to close this if it's not necessary.
Motivation:
Due to using new ByteBuffer initializers from https://github.com/apple/swift-nio/releases/tag/2.18.0 in some tests (specifically,
ByteBuffer(string: ...)), the project will no longer compile if an older version of swift-nio is checked out.Modifications:
Updated swift-nio from 2.16.0 to 2.18.0.
Result:
SPM should now grab the latest version of swift-nio if this version of async-http-client is used.