All internal connection flow should be executed when shutting down #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weissi
reviewed
Jun 22, 2020
weissi
reviewed
Jun 22, 2020
| let waiter = HTTP1ConnectionProvider.Waiter(promise: connectionPromise, setupComplete: setupPromise.futureResult, preference: .indifferent) | ||
| var action = state.acquire(waiter: waiter) | ||
|
|
||
| switch action { |
There was a problem hiding this comment.
nit: you can write this a bit shorter as
guard case .create = action else {
XCTFail("unexpected action \(action)")
return
}
|
|
||
| action = state.offer(connection: connection) | ||
| switch action { | ||
| case .closeAnd(_, let next): |
There was a problem hiding this comment.
isn't this
guard case .closeAnd(_, .closeProvider) = action else {
XCTFail("unexpected action \(action)")
return
}
| let waiter = HTTP1ConnectionProvider.Waiter(promise: connectionPromise, setupComplete: setupPromise.futureResult, preference: .indifferent) | ||
| var action = state.acquire(waiter: waiter) | ||
|
|
||
| switch action { |
There was a problem hiding this comment.
nit: this could be a guard too I think
| } | ||
|
|
||
| action = state.connectFailed() | ||
| switch action { |
artemredkin
added a commit
to artemredkin/async-http-client
that referenced
this pull request
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All internal connection flow should be executed when shutting down.
Motivation:
When we shut the client down, we expect the provider to finish all its tasks, if there are some, and then delete itself and succeed the close promise. Currently, if connection is created unsuccessfully, or available connection is closed/times out before we close it as part of shutdown, those connection will not trigger correct flow.
Modifications:
connectFailednow triggers correct flow when client is.closedtimeoutnow triggers correct flow when client is.closedremoveClosenow triggers correct flow when client is.closedofferis refactoredResult:
Closes #263
Closes #260