Skip to content

fix doc generation setup #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2021
Merged

fix doc generation setup #336

merged 1 commit into from
Jan 24, 2021

Conversation

tomerd
Copy link
Contributor

@tomerd tomerd commented Jan 22, 2021

motivation: fix doc generation - sourcekitten requires Swift 5.2

changes: expose the doc generation task on the 5.3 docker-compose file so we can trigger it there

@tomerd tomerd linked an issue Jan 22, 2021 that may be closed by this pull request
motivation: fix doc generation - sourcekitten has a new version

changes:
* sourcekitten now requires Swift 5.2
* udpate sourcekitten call to use symlink since platform stanze changed between 5.0 and 5.2
* update sourcekitten argument to match the new version
@tomerd
Copy link
Contributor Author

tomerd commented Jan 22, 2021

alternatively we can change the script to pin to the older version

@Lukasa @weissi probably need to check nio as well

cc @ktoso @yim-lee

@ktoso
Copy link
Contributor

ktoso commented Jan 23, 2021

Uff yeah, I may have hit this before 🤔
Will check in other repos

Copy link
Contributor

@weissi weissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@weissi
Copy link
Contributor

weissi commented Jan 23, 2021

alternatively we can change the script to pin to the older version

@Lukasa @weissi probably need to check nio as well

@tomerd NIO seems okay, last release is 2.25.1 and the docs are for that very release.

@tomerd
Copy link
Contributor Author

tomerd commented Jan 24, 2021

alternatively we can change the script to pin to the older version

@Lukasa @weissi probably need to check nio as well

@tomerd NIO seems okay, last release is 2.25.1 and the docs are for that very release.

looking at the code i think its susceptible to the same issue. it likely using a cached version which is why have not surfaced yet

@tomerd tomerd merged commit bbebce3 into swift-server:main Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs are wildly out of date
3 participants