Skip to content

Update Readme to account for Package.swift format #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2021

Conversation

winsmith
Copy link
Contributor

@winsmith winsmith commented Feb 9, 2021

Adding the product dependency to the target by name only produces an error in Xcode 12.4. Instead, the product dependency should be given as a .product.

This PR updates the README with the new format, so that new user's won't stumble over this.

Adding the product dependency to the target by name only produces an error in Xcode 12.4. Instead, the product dependency should be given as a `.product`. Updated the README with the new format, so that new user's won't stumble over this.
@swift-server-bot
Copy link

Can one of the admins verify this patch?

5 similar comments
@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

Copy link
Collaborator

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks.

@Lukasa
Copy link
Collaborator

Lukasa commented Feb 9, 2021

@swift-server-bot test this please

@Lukasa Lukasa added the 🔨 semver/patch No public API change. label Feb 9, 2021
@Lukasa Lukasa merged commit ba845ee into swift-server:main Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants