Skip to content

Update NIO family dependencies to 5.2+ versions and fix deprecations #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 23, 2021
Merged

Update NIO family dependencies to 5.2+ versions and fix deprecations #381

merged 4 commits into from
Jun 23, 2021

Conversation

Davidde94
Copy link
Collaborator

@Davidde94 Davidde94 commented Jun 23, 2021 •
edited
Loading

Updated:

  • NIO
  • NIOSSL
  • NIO Extras
  • NIOTS

Also fix TLSConfiguration.forClient() warnings by converting to TLSConfiguration.makeClientConfiguration(). Also the same for forServer().

@Davidde94 Davidde94 added the 🔨 semver/patch No public API change. label Jun 23, 2021
@Davidde94
Copy link
Collaborator Author

@swift-server-bot test this please

@Davidde94
Copy link
Collaborator Author

(failure was because NIOTS hadn't been released yet, should be good now)

@Davidde94
Copy link
Collaborator Author

Now we have to fix deprecations

@Davidde94 Davidde94 changed the title Update NIO family dependencies to 5.2+ versions Update NIO family dependencies to 5.2+ versions and fix deprecations Jun 23, 2021
@Davidde94 Davidde94 requested a review from Lukasa June 23, 2021 13:36
@Davidde94
Copy link
Collaborator Author

@Lukasa mind taking another look with the deprecation fixes?

@Davidde94 Davidde94 merged commit 102b7e4 into swift-server:main Jun 23, 2021
@Davidde94 Davidde94 deleted the de/update-nio branch June 23, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

@fabianfett fabianfett Awaiting requested review from fabianfett

@glbrntt glbrntt Awaiting requested review from glbrntt

@PeterAdams-A PeterAdams-A Awaiting requested review from PeterAdams-A

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Davidde94 @Lukasa