Skip to content

Add HTTP1ConnectionStateMachine #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fabianfett
Copy link
Member

This PR adds an HTTP1ConnectionStateMachine that shall be used in an upcoming HTTP1ChannelHandler.

This PR doesn't have any tests yet. I would like to get some early feedback on the general form and will then add tests.

@fabianfett fabianfett added this to the HTTP/2 support milestone Jul 7, 2021
@fabianfett fabianfett requested review from Lukasa and glbrntt July 7, 2021 16:51
@fabianfett fabianfett force-pushed the ff-http1-connection-state-machine branch from bb2cc34 to d1a5e4c Compare July 7, 2021 16:52
@Lukasa Lukasa added the semver/none No version bump required. label Jul 7, 2021
Copy link
Collaborator

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally seems reasonable to me.

@fabianfett fabianfett force-pushed the ff-http1-connection-state-machine branch from d1a5e4c to dd3cd57 Compare July 7, 2021 20:29
@fabianfett fabianfett force-pushed the ff-http1-connection-state-machine branch 3 times, most recently from 5e2e805 to de48e1d Compare July 8, 2021 13:52
@fabianfett fabianfett force-pushed the ff-http1-connection-state-machine branch from de48e1d to 0805daa Compare July 8, 2021 13:52
@fabianfett fabianfett merged commit ed44283 into swift-server:main Jul 8, 2021
@fabianfett fabianfett deleted the ff-http1-connection-state-machine branch July 8, 2021 13:59
@fabianfett fabianfett added 🔨 semver/patch No public API change. and removed semver/none No version bump required. labels Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants