Add HTTPConnectionPool Connection as a box type #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
reviewed
Jul 8, 2021
| enum HTTPConnectionPool { | ||
| struct Connection { | ||
| struct Connection: Equatable { |
| private enum Reference { | ||
| // case http1_1(HTTP1Connection) | ||
|
|
||
| #if DEBUG |
There was a problem hiding this comment.
We sometimes want to run tests in release mode: we should probably just define this always and name it to indicate its use in testing.
| } | ||
| } | ||
|
|
||
| #if DEBUG |
There was a problem hiding this comment.
Don't hide this behind debug: use underscores and testOnly (e.g. __testOnly_channel.)
fabianfett
force-pushed
the
ff-add-connection-box
branch
2 times, most recently
from
f12c141 to
01cce0c
Compare
fabianfett
force-pushed
the
ff-add-connection-box
branch
2 times, most recently
from
67b4791 to
0856060
Compare
fabianfett
commented
Jul 8, 2021
fabianfett
force-pushed
the
ff-add-connection-box
branch
from
41e4881 to
77fdb04
Compare
Lukasa
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In our
HTTPConnectionPool.StateMachinewe want to manage HTTPConnection states. However, to ensure that our state machine reflects the outside world it is beneficial if the state machine would hold references to the actual existing connections. Exposing our Connection types directly to the state machine could lead to abuse though. Developers might call actions directly on the Connection within the state machine.Modifications
HTTPConnectionPool.Connectiontype that is a box around an actual connection. The purpose of the box is to ensure no actions are invoked on the connection within the state machine. Further the box can be used for testing the state machine without creating actual connections.Caveats