Skip to content

ConnectionFactory: Replace (Channel, HTTPVersion) with NegotiatedProtocol #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2021
Merged

ConnectionFactory: Replace (Channel, HTTPVersion) with NegotiatedProtocol #399

merged 1 commit into from
Jul 8, 2021

Conversation

fabianfett
Copy link
Member

Modifications

  • Use the previously introduced type NegotiatedProtocol instead of the unhandy tuple (Channel, HTTPVersion)

Result

  • Tidy code

@fabianfett fabianfett requested review from Lukasa and glbrntt July 7, 2021 20:28
@fabianfett fabianfett added this to the HTTP/2 support milestone Jul 7, 2021
@fabianfett fabianfett added the 🔨 semver/patch No public API change. label Jul 7, 2021
@fabianfett
Copy link
Member Author

@swift-server-bot test this please (restart because of known flaky test #371)

@Lukasa Lukasa merged commit 8d4e2b1 into swift-server:main Jul 8, 2021
@fabianfett fabianfett deleted the ff-factory-cleanup branch September 13, 2021 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

@glbrntt glbrntt Awaiting requested review from glbrntt

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
HTTP/2 support
Development

Successfully merging this pull request may close these issues.
2 participants
@fabianfett @Lukasa