Fix bi directional streaming test #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW the shared state isn't an issue: NIO's multithreading rules mean there is no data race here. |
Lukasa
reviewed
Aug 12, 2021
| } | ||
|
|
||
| func didSendRequest(task: HTTPClient.Task<Response>) { | ||
| XCTAssert(self.eventLoop.inEventLoop) |
There was a problem hiding this comment.
Can we remove this assertion? inEventLoop is validly allowed to return false negatives, so we shouldn't assert that it won't. We can add preconditionInEventLoop instead if you want the check.
|
|
||
| let sent = ByteBuffer(integer: index) | ||
| writer.write(.byteBuffer(sent)).flatMap { () -> EventLoopFuture<ByteBuffer?> in | ||
| XCTAssert(delegateEL.inEventLoop, "Always dispatch back to delegate el") |
There was a problem hiding this comment.
Same note here about false positives.
glbrntt
approved these changes
Aug 12, 2021
artemredkin
approved these changes
Aug 12, 2021
fabianfett
force-pushed
the
ff-fix-bi-directional-streaming-test
branch
from
8277b0f to
5875377
Compare
Lukasa
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
HTTPEchoHandlerhas a propertyvar promises: CircularBuffer<EventLoopPromise<Void>>that is currently accessed without lock from different eventLoops (self.serverGroupandself.defaultClient.eventLoopGroup). This in itself may not be a problem. However testing bi directional streaming should not depend on shared promises. Instead the client should write something to an echo server, wait for the body to be echoed and write some more.Changes
Result
No weird shared state in promises between client and server.