Skip to content

Use explicit NIO imports #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 19, 2021
Merged

Use explicit NIO imports #407

merged 5 commits into from
Aug 19, 2021

Conversation

fabianfett
Copy link
Member

In NIO 2.32.0 the NIO module was split up into smaller submodules. This pr updates all imports to import only the needed modules.

fabianfett
fabianfett commented Aug 18, 2021
View reviewed changes
glbrntt
glbrntt reviewed Aug 18, 2021
View reviewed changes
Copy link
Collaborator

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the unhappy CI this looks fine.

@fabianfett fabianfett added the 🔨 semver/patch No public API change. label Aug 19, 2021
@fabianfett fabianfett merged commit eab2a84 into swift-server:main Aug 19, 2021
@fabianfett fabianfett deleted the ff-use-explicit-imports branch August 19, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glbrntt glbrntt glbrntt approved these changes

@Davidde94 Davidde94 Awaiting requested review from Davidde94

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabianfett @glbrntt