Add new HTTPConnectionPool Manager #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: George Barnett <[email protected]>
glbrntt
reviewed
Sep 10, 2021
| final class Manager { | ||
| private typealias Key = ConnectionPool.Key | ||
|
|
||
| enum State { |
| } | ||
|
|
||
| deinit { | ||
| guard case .shutDown = self.state else { |
There was a problem hiding this comment.
What about shutting down? You could call shutdown and not bother waiting for the future to complete as well, I assume?
| } | ||
| } | ||
|
|
||
| func shutdown(on eventLoop: EventLoop) -> EventLoopFuture<Bool> { |
| self.state = .shutDown | ||
| return .done(future) | ||
| } else { | ||
| let promise = eventLoop.makePromise(of: Bool.self) |
There was a problem hiding this comment.
Worth a comment here to indicate when this promise is completed.
|
|
||
| case .shuttingDown(let promise, let soFarUnclean): | ||
| guard self._pools.removeValue(forKey: pool.key) === pool else { | ||
| preconditionFailure("Expected that the pool was ") |
There was a problem hiding this comment.
That suspense is killing me!
Comment on lines
30
to
33
| let eventLoopGroup: EventLoopGroup | ||
| let configuration: HTTPClient.Configuration | ||
| let connectionIDGenerator = Connection.ID.globalGenerator | ||
| let logger: Logger |
Lukasa
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #418