Add tests to observe HTTP/1.1 connection closures #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are a number of tests in
HTTPClientInternalTestthat are hard to reproduce after the refactor. The current implementation has a number of (internal) properties that will be removed with the refactor. For example there is a way to access the underlying channel from a request today. We don't want to expose those things in a new implementation. But we want to test at least the same things. For this reason I added some tests around sudden HTTP/1.1 connection closures that we want to use going forward.Changes
MockConnectionDelegateto HTTP1ConnectionTests.swift, where it is actually used.Result
Easier test after the implementation has been switched over.