Fix potentially flaky HTTPClientTests.testNoBytesSentOverBodyLimit
#426
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If we call
there is no guarantee that
"foo"
will be written to the network. Currently the testtestNoBytesSentOverBodyLimit
assumes this however.Changes
testNoBytesSentOverBodyLimit
does not assume anymore, that bytes will be sent before a close of the connection.XCTAssertEqual
to compareEquatable
errors.