Skip to content

[HTTP1Connection] Handle 101 Switching Protocols #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 28, 2021
Merged

[HTTP1Connection] Handle 101 Switching Protocols #442

merged 2 commits into from
Sep 28, 2021

Conversation

fabianfett
Copy link
Member

Motivation

If we currently receive a 101 Switching Protocols response, we trigger a network reachable crash.

Changes

  • Handle 101 Switching Protocols gracefully

@fabianfett fabianfett added the 🔨 semver/patch No public API change. label Sep 27, 2021
@fabianfett fabianfett added this to the HTTP/2 support milestone Sep 27, 2021
Lukasa
Lukasa approved these changes Sep 28, 2021
View reviewed changes
Copy link
Collaborator

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice patch.

@fabianfett fabianfett added 🆕 semver/minor Adds new public API. and removed 🔨 semver/patch No public API change. labels Sep 28, 2021
@fabianfett fabianfett merged commit 16ad758 into swift-server:main Sep 28, 2021
@fabianfett fabianfett deleted the ff-support-101 branch September 28, 2021 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

@dnadoba dnadoba dnadoba approved these changes

Assignees
No one assigned
Labels
🆕 semver/minor Adds new public API.
Projects
None yet
Milestone
HTTP/2 support
Development

Successfully merging this pull request may close these issues.
3 participants
@fabianfett @Lukasa @dnadoba