Skip to content

Remove deprecated connection pool #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 29, 2021
Merged

Remove deprecated connection pool #443

merged 8 commits into from
Sep 29, 2021

Conversation

fabianfett
Copy link
Member

@fabianfett fabianfett commented Sep 28, 2021 •
edited
Loading

Motivation

After the release of 1.6.0, we can now remove the deprecated connection pool.

Changes

  • Remove now unused Connection/ConnectionPool
  • Removed TaskHandler
  • Remove ResponseReadBuffer
  • Remove unused imports

Result

Less code to maintain.

@fabianfett
Copy link
Member Author

fabianfett commented Sep 28, 2021 •
edited
Loading

Open tasks

  • Need to remove test util: RecordingHandler

@fabianfett fabianfett mentioned this pull request Sep 28, 2021
Merged
@fabianfett fabianfett force-pushed the ff-remove-deprecated-connection-pool branch from f7315d7 to ad759cc Compare September 29, 2021 10:20
@fabianfett fabianfett requested a review from glbrntt September 29, 2021 11:21
@fabianfett fabianfett added the 🔨 semver/patch No public API change. label Sep 29, 2021
@fabianfett fabianfett added this to the HTTP/2 support milestone Sep 29, 2021
@fabianfett fabianfett changed the title [Draft] Remove deprecated connection pool Remove deprecated connection pool Sep 29, 2021
@fabianfett fabianfett marked this pull request as ready for review September 29, 2021 11:21
@fabianfett
Copy link
Member Author

Failing swift-nightly ci because of Sendable requirements.

@fabianfett fabianfett merged commit 2bd8885 into swift-server:main Sep 29, 2021
@fabianfett fabianfett deleted the ff-remove-deprecated-connection-pool branch September 29, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glbrntt glbrntt glbrntt approved these changes

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
HTTP/2 support
Development

Successfully merging this pull request may close these issues.
2 participants
@fabianfett @glbrntt