Skip to content

prepare calculateBackoff(failedAttempt:) to be used in HTTP2StateMachine #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 29, 2021

Conversation

dnadoba
Copy link
Collaborator

@dnadoba dnadoba commented Sep 29, 2021

Motivation

We want to use the same backoff algorithm for HTTP1 and HTTP2.

Changes

Make calculateBackoff(failedAttempt:) a static method on HTTPConnectionPool so it can be used in the HTTP2StateMachine in the future.

//
//===----------------------------------------------------------------------===//

import NIO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import NIO
import NIOCore

@Lukasa Lukasa added the 🔨 semver/patch No public API change. label Sep 29, 2021
@fabianfett fabianfett added this to the HTTP/2 support milestone Sep 29, 2021
@dnadoba dnadoba merged commit 628b942 into swift-server:main Sep 29, 2021
@dnadoba dnadoba deleted the move-calculate-backoff-method branch September 29, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants