Skip to content

remove umbrella NIO imports and add soundness check #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 29, 2021
Merged

remove umbrella NIO imports and add soundness check #446

merged 2 commits into from
Sep 29, 2021

Conversation

dnadoba
Copy link
Collaborator

@dnadoba dnadoba commented Sep 29, 2021

Motivation

We do not want to accidentally import NIO and instead only import NIOCore, NIOPosix or NIOEmbedded.

Changes

  • replace import NIO with corresponding fine-grained import
  • add soundness check (borrowed from swift-nio-http2) so this hopefully never slips in again.

@dnadoba dnadoba merged commit e4e233a into swift-server:main Sep 29, 2021
@dnadoba dnadoba deleted the nio-module-soundness-check branch September 29, 2021 15:42
@fabianfett fabianfett added the 🔨 semver/patch No public API change. label Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dnadoba @Lukasa @fabianfett