[HTTP2ConnectionPool] added HTTP2StateMachine
#447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnadoba
force-pushed
the
dn-http2-state-machine
branch
3 times, most recently
from
660ae31 to
a8679bf
Compare
fabianfett
reviewed
Oct 1, 2021
Sources/AsyncHTTPClient/ConnectionPool/State Machine/HTTPConnectionPool+HTTP2StateMachine.swift
Outdated
Show resolved
Hide resolved
fabianfett
reviewed
Oct 1, 2021
Sources/AsyncHTTPClient/ConnectionPool/State Machine/HTTPConnectionPool+HTTP2StateMachine.swift
Show resolved
Hide resolved
dnadoba
force-pushed
the
dn-http2-state-machine
branch
from
5d14a76 to
810d927
Compare
fabianfett
reviewed
Oct 1, 2021
Sources/AsyncHTTPClient/ConnectionPool/State Machine/HTTPConnectionPool+HTTP2StateMachine.swift
Outdated
Show resolved
Hide resolved
fabianfett
reviewed
Oct 1, 2021
Sources/AsyncHTTPClient/ConnectionPool/State Machine/HTTPConnectionPool+HTTP2StateMachine.swift
Outdated
Show resolved
Hide resolved
fabianfett
reviewed
Oct 1, 2021
| /// | ||
| /// - Complexity: O(*k*), where *k* is the number of elements removed. | ||
| fileprivate mutating func popFirst(max: Int) -> [Element] { | ||
| precondition(max >= 0, "") |
There was a problem hiding this comment.
Add a message, or remove the empty string :)
fabianfett
reviewed
Oct 1, 2021
| // If there aren't any more connections, everything is shutdown | ||
| let isShutdown: StateMachine.ConnectionAction.IsShutdown | ||
| let unclean = !(cleanupContext.cancel.isEmpty && waitingRequests.isEmpty) | ||
| if self.connections.isEmpty { |
There was a problem hiding this comment.
We also need to check if we have still running http1 connections here.
dnadoba
force-pushed
the
dn-http2-state-machine
branch
from
810d927 to
45225b9
Compare
Lukasa
reviewed
Oct 1, 2021
| case keepConnection | ||
| } | ||
|
|
||
| func migrateToHTTP2(_ context: inout HTTP1Connections.HTTP2ToHTTP1MigrationContext) -> MigrateAction { |
There was a problem hiding this comment.
This says migrate to HTTP/2, but the type here is HTTP2toHTTP1 (the other direction). Which way are we going?
| import NIOHTTP2 | ||
|
|
||
| extension HTTPConnectionPool { | ||
| struct HTTP2StateMaschine { |
There was a problem hiding this comment.
Nit:
Suggested change
| struct HTTP2StateMaschine { | |
| struct HTTP2StateMachine { |
Sources/AsyncHTTPClient/ConnectionPool/State Machine/HTTPConnectionPool+RequestQueue.swift
Show resolved
Hide resolved
Lukasa
approved these changes
Oct 4, 2021
dnadoba
force-pushed
the
dn-http2-state-machine
branch
from
1751208 to
a1fc238
Compare
dnadoba
force-pushed
the
dn-http2-state-machine
branch
from
981ee6f to
2e15b58
Compare
|
@swift-server-bot test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One step closer to support HTTP/2 in the new connection pool.
HTTP2StateMaschinewill be integrated inHTTPConnectionPool.StateMachinein a follow up PR.