Double quoted cookie values are supported now. #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: In according to RFC 6265 a cookie value may be placed between double quotes. Modifications: HTTPClient.Cookie ignores now the double quotes at the beginning and the ending of a cookie value. New unit test is added to check it. Result: Quoted cookie values are parsed properly now.
|
Can one of the admins verify this patch? |
6 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
Lukasa
requested changes
Oct 19, 2021
|
@swift-nio-bot test this please |
|
@swift-server-bot test this please |
|
To meet our coding style can you apply the diff from the |
Sure. Fixed it. |
|
@swift-server-bot test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In according to RFC 6265 a cookie value may be placed between double quotes.
Modifications:
HTTPClient.Cookie ignores now the double quotes at the begining and the ending of a cookie value.
New unit test is added to check it.
Result:
Quoted cookie values are parsed properly now.