Skip to content

[HTTP2] Test max streams setting is respected. #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

fabianfett
Copy link
Member

No description provided.

@fabianfett fabianfett requested a review from dnadoba November 3, 2021 13:46
Copy link
Collaborator

@dnadoba dnadoba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


// let's end processing 500 requests. For every finished request, we will execute another one
// right away
while queuer.count > 500 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why a while loop instead of a for _ in 0..<500?

@fabianfett fabianfett force-pushed the ff-http2-test-max-streams branch from 55364b6 to f8f2573 Compare November 3, 2021 14:37
@fabianfett fabianfett added the semver/none No version bump required. label Nov 3, 2021
@fabianfett fabianfett merged commit b6fb33b into swift-server:main Nov 3, 2021
@fabianfett fabianfett deleted the ff-http2-test-max-streams branch November 3, 2021 14:44
@fabianfett fabianfett added this to the HTTP/2 support milestone Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants