Skip to content

[HTTP2] Basic Integration Tests #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2021

Conversation

dnadoba
Copy link
Collaborator

@dnadoba dnadoba commented Nov 8, 2021

No description provided.

initialSettings: NIOHTTP2.nioDefaultSettings
initialSettings: [
// TODO: make max concurrent streams configurable
HTTP2Setting(parameter: .maxConcurrentStreams, value: 10),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maxConcurrentStreams will be made configurable and dynamically changeable in a follow up PR.

@fabianfett fabianfett self-requested a review November 8, 2021 16:52
@dnadoba dnadoba force-pushed the dn-http2-basic-integration-tests branch from b1c00be to 4f0346e Compare November 8, 2021 16:53
@dnadoba dnadoba force-pushed the dn-http2-basic-integration-tests branch from 4f0346e to f3bfa4a Compare November 8, 2021 17:33
@dnadoba dnadoba added the semver/none No version bump required. label Nov 8, 2021
Copy link
Member

@fabianfett fabianfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnadoba dnadoba merged commit cc8e7a6 into swift-server:main Nov 10, 2021
@dnadoba dnadoba deleted the dn-http2-basic-integration-tests branch November 10, 2021 09:47
@fabianfett fabianfett added this to the HTTP/2 support milestone Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants