Add support for multi-resource statements #52
Conversation
|
|
||
| public init(action: String, effect: Effect, resource: String) { | ||
| self.action = [action] |
There was a problem hiding this comment.
I would call the other init() method to avoid duplicating code
|
Hi @sebsto I have ran the soundness.sh script but apparently it changed a few files that weren't supposed to be edited in this PR. You want me to revert the last commit? |
There was a problem hiding this comment.
Thank you for the proposed changes.
I would keep only the change in the file Sources/AWSLambdaEvents/APIGatewayLambdaAuthorizers.swift
Can you revert the other changes made by Swift Format ? I have another PR in progress that takes care of these.
Thanks
|
@swift-server-bot test this please |
1 similar comment
|
@swift-server-bot test this please |
|
@swift-server-bot add to allowlist |
|
@yim-lee can you help and give me permanent authorisation to trigger a test on any PR on this project and on Lambda runtime project ? Thank you |
|
@Buratti Can you also pull and merge the changes from the main branch ? I just merged a PR that has non-conflicting changes on the LambdaAuthorizer.swift file. Thank you and sorry for the trouble |
|
Hi @sebsto! Sure! I'll push the changes in a few hours. |
|
@Buratti one more little soundness fix |
|
Hi @sebsto! I'm sorry, forgot to run it again. It should be good now! |
|
Merged. Thank you ! |
Adds support for multiple actions and resources in the same Policy's Statement
Motivation:
It is common practice to return a statement that describes which integrations are available to the authorized principal. Such statement usually allows the
"execute-api:Invoke"action on a list of integrations ARN.The current design of the
APIGatewayLambdaAuthorizerPolicyResponsedidn't allow that and instead forces the user to generate a long list of statements, each allowing access to just one integration.Modifications:
actionandresourceare now arrays, a new initializer has been added which takes arrays instead of strings. The existing initializer has been changed to automatically initialize a one-element array.A new test has been added to validate the correct encoding and decoding.