Skip to content

[core] duplicate user-agent #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sebsto opened this issue Mar 6, 2025 · 1 comment
Closed

[core] duplicate user-agent #492

sebsto opened this issue Mar 6, 2025 · 1 comment
Assignees
@sebsto
Labels
kind/enhancement Improvements to existing feature. 🔨 semver/patch No public API change.

Comments

@sebsto
Copy link
Contributor

sebsto commented Mar 6, 2025

user-agent String appears at 4+ different places in the code.
Let's make sure we're DRY
@sebsto sebsto self-assigned this Mar 6, 2025
@sebsto sebsto added kind/enhancement Improvements to existing feature. 🔨 semver/patch No public API change. labels Mar 6, 2025
@sebsto
Copy link
Contributor Author

sebsto commented Mar 6, 2025

Fixed by #493

@sebsto sebsto mentioned this issue Mar 6, 2025
Merged
sebsto added a commit that referenced this issue Mar 6, 2025
@sebsto
declare user agent string only once (#493)
bf02bce 
The user-agent string was repeated at 5+ different places in the source
code.
I defined it as a constant in the `ControlPlaneRequest` struct where
other similar constant have been defined and make sure the rest of the
code only uses that constant.

This should address
#492
@sebsto sebsto closed this as completed Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebsto sebsto

Labels
kind/enhancement Improvements to existing feature. 🔨 semver/patch No public API change.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sebsto