[RFC] Adopts *readonly* BaggageContext (Meh for composition) #168
+64
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
requested review from
tomerd and
fabianfett
and removed request for
tomerd
ktoso
force-pushed
the
wip-readonly-baggage
branch
from
25e067c to
209bfb5
Compare
|
We decided readonly sucks and #167 rocks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a "minimal changes" adoption of
Context.It is sub optimal I believe, and we should rather adopt: #167
I post both so they can be compared. The CoW style implementation in #167 is much better and I believe we should adopt that, AND the
Contextlibrary should adopt get/set on the Context.baggage. See that issue for more details.