apply swift-format #380
Merged
apply swift-format #380
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will use the NIO formatting script as suggested. |
|
the NIO swift format script crashes with this error on this code
|
|
@sebsto yes. this is because of an "old" toolchain. I applied the necessary changes manually. On linux it already works as intended (see CI). |
|
The CI stills fails IMHO
|
|
@fabianfett swift format is fixed ! |
fabianfett
reviewed
Sep 30, 2024
There was a problem hiding this comment.
Your local swift format seems to have an issue with package. Those breaks aren't needed. In #379 CI passed without those weird breaks.
…bda-runtime into sebsto/swift-format
|
Fixed - not sure where it came from, maybe my first pass of swift-format without using swift-nio's script |
fabianfett
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply swift-format to
SourcesandPluginsdirectories