-
Notifications
You must be signed in to change notification settings - Fork 113
[TestServer] Fix 488 and add simple test lambda #489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you @fabianfett for this patch. I take the responsibility of the original error :-) I just tested it with the APIGateway example (as per "Steps to reproduce" in the issue description). I confirm this fixes the error. Can you delete from this PR the On a side not, the CI fails to compile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the exception of the example code, LGTM
Package.swift
Outdated
@@ -85,6 +85,12 @@ let package = Package( | |||
.byName(name: "AWSLambdaTesting") | |||
] | |||
), | |||
.executableTarget( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was for your own test. I think we can remove this
Sources/HelloWorldLambda/main.swift
Outdated
@@ -0,0 +1,29 @@ | |||
//===----------------------------------------------------------------------===// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file can be remove for the PR too,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes: #488