Skip to content

[TestServer] Fix 488 and add simple test lambda #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 4, 2025
Merged

[TestServer] Fix 488 and add simple test lambda #489

merged 3 commits into from
Mar 4, 2025

Conversation

fabianfett
Copy link
Member

Fixes: #488

@fabianfett fabianfett requested a review from sebsto March 1, 2025 10:41
@fabianfett fabianfett added the 🔨 semver/patch No public API change. label Mar 1, 2025
@sebsto
Copy link
Contributor

sebsto commented Mar 1, 2025

Thank you @fabianfett for this patch. I take the responsibility of the original error :-)

I just tested it with the APIGateway example (as per "Steps to reproduce" in the issue description). I confirm this fixes the error.

Can you delete from this PR the HelloWorldLambda and revert back the Package.swift ?

On a side not, the CI fails to compile swift-nio on the Swift toolchain nightly build. But this is a separate issue and will not block the merging of this change.

Copy link
Contributor

@sebsto sebsto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the exception of the example code, LGTM

Package.swift Outdated
@@ -85,6 +85,12 @@ let package = Package(
.byName(name: "AWSLambdaTesting")
]
),
.executableTarget(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was for your own test. I think we can remove this

@@ -0,0 +1,29 @@
//===----------------------------------------------------------------------===//
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file can be remove for the PR too,

Copy link
Contributor

@sebsto sebsto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebsto sebsto merged commit 03876f6 into main Mar 4, 2025
30 of 31 checks passed
@sebsto sebsto deleted the ff-fix-488 branch March 4, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[core] LocalServer does not report errors correctly
2 participants