[plugin] Fix #505 : resources are not included in the archive on Linux #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The unit test "PR / Integration Tests / Test archive plugin (ResourcesPackaging) (pull_request)" fails. This is expected |
sebsto
changed the title
|
The PR now fixes both the CI script and the plugin. |
sebsto
changed the title
sebsto
commented
Mar 14, 2025
| unzip -l "${ZIP_FILE}" | grep --silent hello.txt | ||
| SUCCESS=$? | ||
| if [ "$SUCCESS" -eq 1 ]; then |
There was a problem hiding this comment.
I know these two lines can be merged as one but I favored readability over concision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resources are not included in the archive on Linux
#505
In addition, the script that checks if the resources are correctly included in an archive when building on Linux is not working.
It failed to detected missing resources.
This patch fix both the plugin and the CI script