Skip to content

[AHC Transport] Async bodies + swift-http-types adoption #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 27, 2023
Merged

[AHC Transport] Async bodies + swift-http-types adoption #16

merged 10 commits into from
Sep 27, 2023

Conversation

czechboy0
Copy link
Collaborator

@czechboy0 czechboy0 commented Sep 7, 2023 •
edited
Loading

Motivation

AHC transport changes of the approved proposals apple/swift-openapi-generator#255 and apple/swift-openapi-generator#254.

Modifications

  • Adapts to the runtime changes, depends on HTTPTypes now.
  • Both request and response streaming works.

Result

Transport works with the 0.3.0 runtime API of.

Test Plan

Adapted tests.

This was linked to issues Sep 8, 2023
Investigate adopting swift-http-types apple/swift-openapi-generator#101
Closed
Make request/response bodies an async sequence of bytes apple/swift-openapi-generator#9
Closed
@czechboy0 czechboy0 changed the title [WIP] [AHC Transport] Async bodies + swift-http-types adoption [AHC Transport] Async bodies + swift-http-types adoption Sep 18, 2023
@czechboy0 czechboy0 marked this pull request as ready for review September 18, 2023 13:59
simonjbeaumont
simonjbeaumont reviewed Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@simonjbeaumont simonjbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'll hold off approving until we land runtime.

simonjbeaumont
simonjbeaumont approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@simonjbeaumont simonjbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @dnadoba ?

dnadoba
dnadoba approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@dnadoba dnadoba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@czechboy0 czechboy0 merged commit 0a0c648 into swift-server:main Sep 27, 2023
@czechboy0 czechboy0 deleted the hd-adopt-http-types branch September 27, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjbeaumont simonjbeaumont simonjbeaumont approved these changes

@dnadoba dnadoba dnadoba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate adopting swift-http-types Make request/response bodies an async sequence of bytes
3 participants
@czechboy0 @simonjbeaumont @dnadoba