Sanitize Dimensions #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrLotU
added a commit
that referenced
this pull request
Jun 20, 2022
* Sanitize Dimensions (#68) * Add failing test for sanitising dimension * Fix test * Add new DimensionsSanitizer * Remove labels parametrisation (#63) * Stop leaking 'le', 'quantile' in Summary/Histogram labels, remove labels parametrisation * chore: Remove base labels protocol and add ExpressibleByArrayLiteral * chore: Cleanup documentation. Remove deprecations Co-authored-by: Jari (LotU) <[email protected]> * Add async/await APIs (#67) * Add async/await APIs * Revert unrelated change * Add #if swift for 5.2 * Fix Swift version number check * Add task API Co-authored-by: Tim Condon <[email protected]> Co-authored-by: Anton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sanitize dimensions to avoid scraping from breaking. Resolves #65 and #38
Checklist
Motivation and Context
If dimensions aren't sanitized then Prometheus breaks with errors like
Description
Run dimensions through a sanitizer. Uses a new
DimensionsSanitizeras uppercase ASCII is allowed. (It looks like regular labels should allow uppercase as well but I didn't want to change that).Also split out sanitiser types into their own files