fix repeated shutdown issue on linux #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
force-pushed
the
fix/repeating-termination
branch
2 times, most recently
from
075e968 to
2d5d07d
Compare
yim-lee
approved these changes
Aug 19, 2021
motivation: repeatedly calling shutdown in linux was broken due to multiple calls to singal() which work on darwin but not linux changes: * conditionalize the call to signal to once per process * add test
tomerd
force-pushed
the
fix/repeating-termination
branch
from
2d5d07d to
f1a5378
Compare
|
cc @oc243 |
|
Thanks so much @tomerd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: repeatedly calling shutdown in linux was broken due to multiple calls to singal() which work on darwin but not linux
changes: