when shutdownIfNotStarted is set to false, dont shutdown items that failed to start #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jazzy issues failing CI, need #108 first |
yim-lee
reviewed
Sep 2, 2021
| } | ||
| // shutdown called while starting | ||
| if case .shuttingDown = self.stateLock.withLock({ self.state }) { | ||
| return callback(index, nil) | ||
| let started = index < tasks.count ? Array(tasks.prefix(index + 1)) : tasks |
There was a problem hiding this comment.
Why would the task at index be considered started?
There was a problem hiding this comment.
this is a non-error case, meaning the task was started successfully. do you see something else?
|
@weissi do you want to test this one (before we tag) to make sure it addressed your concern? |
…ilaed to start motivation: improve confusing behavior changes: * change startTask to return an array of started tasks instead of an index * only shutdown successfully started tasks or ones that have explicitly set shutdownIfNotStarted to true * add and adjust tests
tomerd
force-pushed
the
fix/shutdown-on-error
branch
from
962f824 to
2b66515
Compare
yim-lee
approved these changes
Sep 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: improve confusing behavior
changes: