shutdown any task that have shutdownIfNotStarted set to true when shutting down a never-started-lifecycle #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tting down a never-started-lifecycle motivation: more reliable shutdown in edge cases where lifecycle never gets started changes: when shutting down an idle lifecycle, try to shutdown any tasks that have shutdownIfNotStarted set to true
|
jazzy issues failing CI, need #108 first |
yim-lee
approved these changes
Sep 2, 2021
fabianfett
approved these changes
Sep 2, 2021
thats a good idea. was planning to rework docs in a following PR anyways, so will do then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: more reliable shutdown in edge cases where lifecycle never gets started
changes: when shutting down an idle lifecycle, try to shutdown any tasks that have shutdownIfNotStarted set to true