Use swift-atomics from v1.0.0 #114
Conversation
|
Can one of the admins verify this patch? |
7 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
@swift-server-bot add to allowlist |
Co-authored-by: tomer doron <[email protected]>
|
welp, look like atomics now requires 5.3? |
The commit message for this references apple/swift-atomics#22. Issue seems to be about supporting 5.2 and above but instead they updated to 5.3. :-/ |
well the code as fallback for using the "old" atomics, we just need to move the check to < 5.3: https://github.com/swift-server/swift-service-lifecycle/blob/main/Sources/Lifecycle/Atomics.swift#L15 |
|
@tomerd Any reason this cannot be merged yet. It fails on the nightly but that seems to be related to |
Now swift-atomics has hit v1.0.0 we should use it