Skip to content

Use swift-atomics from v1.0.0 #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 7, 2021

Conversation

adam-fowler
Copy link
Member

Now swift-atomics has hit v1.0.0 we should use it

@swift-server-bot
Copy link

Can one of the admins verify this patch?

7 similar comments
@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@adam-fowler adam-fowler linked an issue Sep 27, 2021 that may be closed by this pull request
@tomerd
Copy link
Contributor

tomerd commented Sep 27, 2021

@swift-server-bot add to allowlist

Co-authored-by: tomer doron <[email protected]>
@tomerd
Copy link
Contributor

tomerd commented Sep 27, 2021

welp, look like atomics now requires 5.3?

@adam-fowler
Copy link
Member Author

welp, look like atomics now requires 5.3?

The commit message for this references apple/swift-atomics#22. Issue seems to be about supporting 5.2 and above but instead they updated to 5.3. :-/

@tomerd
Copy link
Contributor

tomerd commented Sep 28, 2021

The commit message for this references apple/swift-atomics#22. Issue seems to be about supporting 5.2 and above but instead they updated to 5.3. :-/

well the code as fallback for using the "old" atomics, we just need to move the check to < 5.3: https://github.com/swift-server/swift-service-lifecycle/blob/main/Sources/Lifecycle/Atomics.swift#L15

@adam-fowler
Copy link
Member Author

@tomerd Any reason this cannot be merged yet. It fails on the nightly but that seems to be related to Sendable issues in NIO.

@tomerd tomerd merged commit 531c6f8 into swift-server:main Oct 7, 2021
@tomerd tomerd added the 🔨 semver/patch No public API change. label Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Swift Atomics v1.0.0
3 participants