Provide a ServiceGroupConfiguration initializer without `gracefulSh…
#147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utdownSignals` signals # Motivation When using the `ServiceGroup` in non-top-level setups such as inside a `Service.run()` method then it is confusing if you are forced to pass `gracefulShutdownSignals`. # Modification This PR adds a new initializer to `ServiceGroupConfiguration` which takes no arguments. # Result Less confusion when using the service group inside a non-top-level context.
|
Closing this in favour of: #148 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…utdownSignals` signals
Motivation
When using the
ServiceGroupin non-top-level setups such as inside aService.run()method then it is confusing if you are forced to passgracefulShutdownSignals.Modification
This PR adds a new initializer to
ServiceGroupConfigurationwhich takes no arguments.Result
Less confusion when using the service group inside a non-top-level context.