Add async gracefulShutdown function to wait on graceful shutdown trigger #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
requested changes
Sep 12, 2023
gjcairo
force-pushed
the
wait-for-shutdown
branch
from
81f64d9 to
40a135f
Compare
|
@swift-server-bot test this please |
|
@swift-server-bot add to allowlist |
gjcairo
changed the title
|
@swift-server-bot add to allowlist |
|
@swift-server-bot test this please |
gjcairo
force-pushed
the
wait-for-shutdown
branch
2 times, most recently
from
dafe956 to
87d3e2b
Compare
|
@swift-server-bot test this please |
gjcairo
force-pushed
the
wait-for-shutdown
branch
from
87d3e2b to
461e62e
Compare
|
@swift-server-bot test this please |
gjcairo
force-pushed
the
wait-for-shutdown
branch
from
461e62e to
07eb63b
Compare
gjcairo
force-pushed
the
wait-for-shutdown
branch
from
07eb63b to
fd16056
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Sometimes, it's useful to wait for graceful shutdown to happen before resuming execution on a task.
This can be of particular interest when we don't have anything to do in a Service's
runmethod but want to make sure some cleanup happens on graceful shutdown.In this scenario, we can achieve this by calling
await gracefulShutdown()inrun(), followed by whatever cleanup we must do.Modification
This PR adds a new
gracefulShutdown()function to theGracefulShutdownsuite.Result
A new
gracefulShutdown()method in theGracefulShutdownsuite.