setup shutdown hooks on ServiceLifecycle::startAndWait #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
force-pushed
the
fix/68
branch
5 times, most recently
from
95d15fb to
87d01c5
Compare
motivation: fix startAndWait to work as advertised changes: * extract shutdown setup to a func and call it from both start and startAndWait * add test * fix api doc * fixi jazzy xenial issue (fixes ci)
tomerd
commented
Aug 8, 2020
| @@ -18,7 +18,7 @@ RUN apt-get update && apt-get install -y lsof dnsutils netcat-openbsd net-tools | |||
|
|
|||
| # ruby and jazzy for docs generation | |||
| RUN apt-get update && apt-get install -y ruby ruby-dev libsqlite3-dev | |||
| RUN gem install jazzy --no-ri --no-rdoc | |||
| RUN if [ "${ubuntu_version}" != "xenial" ] ; then gem install jazzy --no-ri --no-rdoc ; fi | |||
There was a problem hiding this comment.
unrelated jazzy issue on ubuntu 16.04, but required for CI to pass
|
closes #68 |
tanner0101
approved these changes
Aug 8, 2020
| @@ -91,6 +91,55 @@ final class ServiceLifecycleTests: XCTestCase { | |||
| XCTAssertEqual(item.state, .shutdown, "expected item to be shutdown") | |||
| } | |||
|
|
|||
| func testStartAndWaitShutdownWithSignal() { | |||
| if ProcessInfo.processInfo.environment["SKIP_SIGNAL_TEST"].flatMap(Bool.init) ?? false { | |||
| print("skipping testStartAndWaitShutdownWithSignal") | |||
There was a problem hiding this comment.
You might be able to use XCTSkipUnless here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: fix startAndWait to work as advertised
changes: